Skip to content

Commit

Permalink
Use add_columns instead of add_entity
Browse files Browse the repository at this point in the history
This is a step towards converting the _get_nested_collection_attributes
method from Query to Select. The add_entity method does not exist on
Select; add_column should work the same way, in theory...
  • Loading branch information
jdavcs committed Nov 16, 2023
1 parent 75c49bf commit fb46470
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/galaxy/model/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -6184,7 +6184,7 @@ def attribute_columns(column_collection, attributes, nesting_level=None):
.add_columns(*attribute_columns(DatasetPermissions, dataset_permission_attributes))
)
for entity in return_entities:
q = q.add_entity(entity)
q = q.add_columns(entity)
if entity == DatasetCollectionElement:
q = q.filter(entity.id == dce.c.id)
return q.distinct().order_by(*order_by_columns)
Expand Down

0 comments on commit fb46470

Please sign in to comment.