Skip to content

Commit

Permalink
Merge pull request #18946 from guerler/add_ngl
Browse files Browse the repository at this point in the history
Migrate NGL viewer to npm package
  • Loading branch information
dannon authored Oct 18, 2024
2 parents e9f7316 + d489cc1 commit c5d89e5
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 109 deletions.
3 changes: 1 addition & 2 deletions client/gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const STATIC_PLUGIN_BUILD_IDS = [
"jqplot/jqplot_bar",
"media_player",
"mvpapp",
"ngl",
"nora",
"nvd3/nvd3_bar",
"openlayers",
Expand All @@ -39,7 +38,7 @@ const STATIC_PLUGIN_BUILD_IDS = [
"ts_visjs",
"venn",
];
const INSTALL_PLUGIN_BUILD_IDS = ["msa"]; // todo: derive from XML
const INSTALL_PLUGIN_BUILD_IDS = ["ngl", "msa"]; // todo: derive from XML
const DIST_PLUGIN_BUILD_IDS = ["new_user"];
const PLUGIN_BUILD_IDS = Array.prototype.concat(DIST_PLUGIN_BUILD_IDS, STATIC_PLUGIN_BUILD_IDS);

Expand Down
10 changes: 5 additions & 5 deletions config/plugins/visualizations/example/config/example.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@
<type>setting_type</type>
</input>
</settings>
<groups>
<tracks>
<input>
<name>group_input</name>
<help>group help</help>
<type>group_type</type>
<name>track_input</name>
<help>track help</help>
<type>track_type</type>
</input>
</groups>
</tracks>
<specs>
<spec_name>spec_value</spec_name>
</specs>
Expand Down
5 changes: 4 additions & 1 deletion config/plugins/visualizations/ngl/config/ngl.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
<params>
<param type="dataset" var_name_in_template="hda" required="true">dataset_id</param>
</params>
<entry_point entry_point_type="chart" src="dist/ngl.js"/>
<requirements>
<requirement type="npm" version="0.0.8" package="@galaxyproject/ngl"/>
</requirements>
<entry_point entry_point_type="script" src="dist/index.js" css="dist/index.css" />
<settings>
<input>
<label>Quality</label>
Expand Down
23 changes: 0 additions & 23 deletions config/plugins/visualizations/ngl/package.json

This file was deleted.

48 changes: 0 additions & 48 deletions config/plugins/visualizations/ngl/src/ngl.js

This file was deleted.

30 changes: 0 additions & 30 deletions config/plugins/visualizations/ngl/src/viewer.js

This file was deleted.

0 comments on commit c5d89e5

Please sign in to comment.