Skip to content

Commit

Permalink
Remove unneeded/wrong parameters in method calls
Browse files Browse the repository at this point in the history
Fix the following mypy errors:

```
lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py:108: error:
Unexpected keyword argument "filepath" for "commit_tar_to_repository" of
"ShedTwillTestCase"  [call-arg]
                self.commit_tar_to_repository(
                ^
lib/tool_shed/test/base/twilltestcase.py:1156: note: "commit_tar_to_repository" of "ShedTwillTestCase" defined here
lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py:108: error:
Unexpected keyword argument "valid_tools_only" for "commit_tar_to_repository" of
"ShedTwillTestCase"  [call-arg]
                self.commit_tar_to_repository(
                ^
lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py:108: error:
Unexpected keyword argument "uncompress_file" for "commit_tar_to_repository" of
"ShedTwillTestCase"  [call-arg]
                self.commit_tar_to_repository(
                ^
lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py:108: error:
Unexpected keyword argument "remove_repo_files_not_in_tar" for
"commit_tar_to_repository" of "ShedTwillTestCase"  [call-arg]
                self.commit_tar_to_repository(
                ^
lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py:108: error:
Unexpected keyword argument "strings_not_displayed" for
"commit_tar_to_repository" of "ShedTwillTestCase"; did you mean
"strings_displayed"?  [call-arg]
                self.commit_tar_to_repository(
                ^

lib/tool_shed/test/functional/test_0420_citable_urls_for_repositories.py:170: error:
Need type annotation for "strings_not_displayed_in_iframe" (hint:
"strings_not_displayed_in_iframe: List[<type>] = ...")  [var-annotated]
            strings_not_displayed_in_iframe = []
            ^
```
  • Loading branch information
nsoranzo committed Oct 24, 2023
1 parent abb6f73 commit 9a356c1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ def test_0025_load_view_page_for_previous_revision(self):
if not self.is_v2:
strings_displayed_in_iframe.append("Link to this repository revision:")
strings_displayed_in_iframe.append(f"{self.url}/view/user1/filtering_0420/{first_changeset_hash}")
strings_not_displayed_in_iframe = []
self.load_citable_url(
username="user1",
repository_name="filtering_0420",
Expand All @@ -176,7 +175,6 @@ def test_0025_load_view_page_for_previous_revision(self):
encoded_repository_id=encoded_repository_id,
strings_displayed=strings_displayed,
strings_displayed_in_iframe=strings_displayed_in_iframe,
strings_not_displayed_in_iframe=strings_not_displayed_in_iframe,
)

def test_0030_load_sharable_url_with_invalid_changeset_revision(self):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,7 @@ def test_0015_create_tool_repository(self):
self.commit_tar_to_repository(
repository,
"blast/blastxml_to_top_descr.tar",
filepath=None,
valid_tools_only=True,
uncompress_file=True,
remove_repo_files_not_in_tar=True,
commit_message="Uploaded blastxml_to_top_descr tarball.",
strings_displayed=[],
strings_not_displayed=[],
)

def test_0020_verify_tool_repository(self):
Expand Down

0 comments on commit 9a356c1

Please sign in to comment.