look for changes in both id and stored id for better reload control

galaxyproject · Jan 19, 2024 · 8506769 · 8506769
1 parent 064654d
commit 8506769
Showing 1 changed file with 16 additions and 8 deletions.
diff --git a/client/src/entry/analysis/modules/WorkflowEditor.vue b/client/src/entry/analysis/modules/WorkflowEditor.vue
@@ -37,19 +37,27 @@ export default {
     },
     methods: {
         async getEditorConfig() {
-            const storedWorkflowId = Query.get("id");
-            const workflowId = Query.get("workflow_id");
+            let reloadEditor = true;
+
+            // this will only be the case the first time the route updates from a new workflow
+            if (!this.storedWorkflowId && !this.workflowId) {
+                reloadEditor = false;
+            }
+
+            this.storedWorkflowId = Query.get("id");
+            this.workflowId = Query.get("workflow_id");
+
             const params = {};
-            if (workflowId) {
-                params.workflow_id = workflowId;
-            } else if (storedWorkflowId) {
-                params.id = storedWorkflowId;
+
+            if (this.workflowId) {
+                params.workflow_id = this.workflowId;
+            } else if (this.storedWorkflowId) {
+                params.id = this.storedWorkflowId;
             }
 
-            const previousId = this.editorConfig?.id;
             this.editorConfig = await urlData({ url: "/workflow/editor", params });
 
-            if (previousId !== undefined && previousId !== this.editorConfig?.id) {
+            if (reloadEditor) {
                 this.editorReloadKey += 1;
             }
         },