Skip to content

Commit

Permalink
Adds ID to toolbox panel
Browse files Browse the repository at this point in the history
Adds an ID attribute to the toolbox panel.
Updates the tool opening logic in the workflow editor to open the toolbox panel using the activity bar before selecting tool
  • Loading branch information
itisAliRH committed Nov 17, 2024
1 parent 03296be commit 7e4ca5c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion client/src/components/Panels/ToolPanel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ watch(
</script>

<template>
<div v-if="arePanelsFetched" class="unified-panel" aria-labelledby="toolbox-heading">
<div v-if="arePanelsFetched" id="toolbox-panel" class="unified-panel" aria-labelledby="toolbox-heading">
<div unselectable="on">
<div class="unified-panel-header-inner mx-3 my-2 d-flex justify-content-between">
<PanelViewMenu
Expand Down
1 change: 1 addition & 0 deletions client/src/utils/navigation/navigation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -899,6 +899,7 @@ tour:
tools:
selectors:
activity: '#activity-tools'
workflows_activity: '#activity-workflow-editor-tools'
body: '#center #tool-card-body'
execute: '#execute'
help: 'div.form-help'
Expand Down
3 changes: 3 additions & 0 deletions lib/galaxy/selenium/navigates_galaxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -1643,6 +1643,9 @@ def invocation_index_table_elements(self):
return invocations.invocations_table_rows.all()

def tool_open(self, tool_id, outer=False):
if self.wait_for_selector_absent_or_hidden('#toolbox-panel', wait_type=WAIT_TYPES.UX_RENDER):
self.components.tools.workflows_activity.wait_for_and_click()

if outer:
tool_link = self.components.tool_panel.outer_tool_link(tool_id=tool_id)
else:
Expand Down

0 comments on commit 7e4ca5c

Please sign in to comment.