Skip to content

Commit

Permalink
Include exception info when something goes wrong while refreshing tokens
Browse files Browse the repository at this point in the history
```
An error occurred when refreshing user token: (invalid_request) Missing Code
```

is the message we're currently logging, that's not enough to do anything
with.
  • Loading branch information
mvdbeek committed Apr 17, 2024
1 parent 3c2db48 commit 6da24f2
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions lib/galaxy/authnz/managers.py
Original file line number Diff line number Diff line change
Expand Up @@ -340,9 +340,8 @@ def refresh_expiring_oidc_tokens_for_provider(self, trans, auth):
if refreshed:
log.debug(f"Refreshed user token via `{auth.provider}` identity provider")
return True
except Exception as e:
msg = f"An error occurred when refreshing user token: {e}"
log.error(msg)
except Exception:
log.exception("An error occurred when refreshing user token")
return False

def refresh_expiring_oidc_tokens(self, trans, user=None):
Expand Down

0 comments on commit 6da24f2

Please sign in to comment.