Skip to content

Commit

Permalink
Fix output addition to history if input name is same as output name
Browse files Browse the repository at this point in the history
CWL output names are namespaced, so in that case the previous check
doesn't work.
  • Loading branch information
mvdbeek authored and nsoranzo committed Dec 5, 2024
1 parent 1cb15eb commit 53c91ba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/galaxy/tools/actions/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ def handle_output(name, output, hidden=None):
)
# Add all the top-level (non-child) datasets to the history unless otherwise specified
for name, data in out_data.items():
if name not in incoming and name not in child_dataset_names:
if getattr(data, "hid", None) is None or (name not in incoming and name not in child_dataset_names):
# don't add already existing datasets, i.e. async created
history.stage_addition(data)
history.add_pending_items(set_output_hid=set_output_hid)
Expand Down

0 comments on commit 53c91ba

Please sign in to comment.