Skip to content

Commit

Permalink
Fix test_singularity_container_test test
Browse files Browse the repository at this point in the history
(which started failing since ubuntu-latest was moved to 24.04)
by upgrading apptainer to >=1.3.3 to include
apptainer/apptainer#2262 .

Fix:

```
>       assert "samtools:1.0--1" in results["passed"], results
E       AssertionError:
E       {'failed': [{'commands': ['python -c "import pyBigWig; assert(pyBigWig.numpy '
E                                 '== 1); assert(pyBigWig.remote == 1)"'],
E                    'container': 'pybigwig:0.3.22--py36h54a71a5_0',
E                    'errors': [{'command': 'python -c "import pyBigWig; '
E                                           'assert(pyBigWig.numpy == 1); '
E                                           'assert(pyBigWig.remote == 1)"',
E                                'output': '\x1b[91mERROR  : Could not write info to '
E                                          'setgroups: Permission denied\n'
E                                          '\x1b[0m\x1b[91mERROR  : Error while '
E                                          'waiting event for user namespace mappings: '
E                                          'no event received\n'
E                                          '\x1b[0m'},
E                               {'import': 'pyBigWig',
E                                'output': '\x1b[91mERROR  : Could not write info to '
E                                          'setgroups: Permission denied\n'
E                                          '\x1b[0m\x1b[91mERROR  : Error while '
E                                          'waiting event for user namespace mappings: '
E                                          'no event received\n'
E                                          '\x1b[0m'}],
E                    'import_lang': 'python -c',
E                    'imports': ['pyBigWig']},
E                   {'commands': ['samtools view --help 2>&1 | grep Notes > /dev/null'],
E                    'container': 'samtools:1.0--1',
E                    'errors': [{'command': 'samtools view --help 2>&1 | grep Notes > '
E                                           '/dev/null',
E                                'output': '\x1b[91mERROR  : Could not write info to '
E                                          'setgroups: Permission denied\n'
E                                          '\x1b[0m\x1b[91mERROR  : Error while '
E                                          'waiting event for user namespace mappings: '
E                                          'no event received\n'
E                                          '\x1b[0m'}],
E                    'import_lang': 'python -c'}],
E        'notest': ['yasm:1.3.0--0'],
E        'passed': []}
E       assert 'samtools:1.0--1' in []
```

Also:
- Improve assertion messages to facilitate debugging
  • Loading branch information
nsoranzo committed Dec 17, 2024
1 parent b100c1e commit 4e650b4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/mulled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ jobs:
key: tox-cache-${{ runner.os }}-${{ steps.full-python-version.outputs.version }}-${{ hashFiles('galaxy root/requirements.txt') }}-mulled
- name: Install Apptainer's singularity
uses: eWaterCycle/setup-apptainer@v2
with:
apptainer-version: 1.3.6 # https://github.com/eWaterCycle/setup-apptainer/pull/68
- name: Install tox
run: pip install tox
- name: Run tests
Expand Down
2 changes: 1 addition & 1 deletion pytest.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[pytest]
addopts = --doctest-continue-on-failure --verbosity=1
addopts = --doctest-continue-on-failure --verbosity=1 --showlocals
asyncio_mode = auto
log_level = DEBUG
# Install pytest-memray and set memray to true here to enable memory profiling of tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@ def test_singularity_container_test(tmp_path) -> None:
"singularity",
tmp_path,
)
assert "samtools:1.0--1" in results["passed"]
assert "pybigwig:0.3.22--py36h54a71a5_0" in results["passed"]
assert "yasm:1.3.0--0" in results["notest"]
assert "samtools:1.0--1" in results["passed"], results
assert "pybigwig:0.3.22--py36h54a71a5_0" in results["passed"], results
assert "yasm:1.3.0--0" in results["notest"], results

0 comments on commit 4e650b4

Please sign in to comment.