Skip to content

Commit

Permalink
route to invocation view instead of expanding within invocation list
Browse files Browse the repository at this point in the history
This allows users to directly go back and forth between dedicated full-center-panel invocation summaries and the invocations list.
  • Loading branch information
ahmedhamidawan committed Apr 16, 2024
1 parent 5360a7c commit 3249751
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 7 deletions.
12 changes: 6 additions & 6 deletions client/src/components/Workflow/InvocationsList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@
@click.stop="swapRowDetails(data)" />
</template>
<template v-slot:cell(workflow_id)="data">
<div
v-b-tooltip.hover.top
:title="getStoredWorkflowNameByInstanceId(data.item.workflow_id)"
class="truncate">
<b-link href="#" @click.stop="swapRowDetails(data)">
<div class="truncate">
<router-link
v-b-tooltip.hover.top
:title="`Go to detailed view for '${getStoredWorkflowNameByInstanceId(data.item.workflow_id)}'`"
:to="invocationLink(data.item)">
{{ getStoredWorkflowNameByInstanceId(data.item.workflow_id) }}
</b-link>
</router-link>
</div>
</template>
<template v-slot:cell(history_id)="data">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<b-tabs v-if="invocation">
<b-tabs v-if="invocation" :class="{ 'position-relative': isInvocationRoute }">
<b-tab title="Summary" active>
<WorkflowInvocationSummary
class="invocation-summary"
Expand All @@ -25,6 +25,12 @@
<LoadingSpan message="Waiting to complete invocation" />
</b-alert>
</b-tab>
<router-link to="/workflows/invocations">
<b-button v-if="isInvocationRoute" class="position-absolute text-decoration-none" style="top: 0; right: 0">
<i class="fa fa-arrow-left mr-1" />
Go to Invocations List
</b-button>
</router-link>
</b-tabs>
<b-alert v-else variant="info" show>
<LoadingSpan message="Loading invocation" />
Expand Down Expand Up @@ -104,6 +110,9 @@ export default {
const jobsSummary = this.invocationStore.getInvocationJobsSummaryById(this.invocationId);
return !jobsSummary ? null : jobsSummary;
},
isInvocationRoute() {
return this.$route.path.includes(`/workflows/invocations/${this.invocationId}`);
},
},
created: function () {
this.pollStepStatesUntilTerminal();
Expand Down

0 comments on commit 3249751

Please sign in to comment.