Skip to content

Commit

Permalink
Merge pull request #19079 from ahmedhamidawan/fetch_invocation_id_onc…
Browse files Browse the repository at this point in the history
…e_job_info

[24.0] Fetch invocation id only once on the job info page
  • Loading branch information
mvdbeek authored Oct 31, 2024
2 parents 19811a6 + 2cae82c commit 2311374
Showing 1 changed file with 16 additions and 12 deletions.
28 changes: 16 additions & 12 deletions client/src/components/JobInformation/JobInformation.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ import { JobDetailsProvider } from "components/providers/JobProvider";
import UtcDate from "components/UtcDate";
import { formatDuration, intervalToDuration } from "date-fns";
import JOB_STATES_MODEL from "utils/job-states-model";
import { computed, ref } from "vue";
import { computed, ref, watch } from "vue";
import { invocationForJob } from "@/api/invocations";
import DecodedId from "../DecodedId.vue";
import CodeRow from "./CodeRow.vue";
const job = ref(null);
const invocationId = ref(null);
const invocationId = ref(undefined);
const props = defineProps({
job_id: {
Expand Down Expand Up @@ -41,9 +41,6 @@ const metadataDetail = ref({
function updateJob(newJob) {
job.value = newJob;
if (newJob) {
fetchInvocation(newJob.id);
}
}
function filterMetadata(jobMessages) {
Expand All @@ -57,14 +54,21 @@ function filterMetadata(jobMessages) {
});
}
async function fetchInvocation(jobId) {
if (jobId) {
const invocation = await invocationForJob({ jobId: jobId });
if (invocation) {
invocationId.value = invocation.id;
// Fetches the invocation for the given job id to get the associated invocation id
watch(
() => props.job_id,
async (newId, oldId) => {
if (newId && (invocationId.value === undefined || newId !== oldId)) {
const invocation = await invocationForJob({ jobId: newId });
if (invocation) {
invocationId.value = invocation.id;
} else {
invocationId.value = null;
}
}
}
}
},
{ immediate: true }
);
</script>

<template>
Expand Down

0 comments on commit 2311374

Please sign in to comment.