Misc. refactoring and enhancements to create_point_release #25
+212
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap code blocks in try/finally to ensure galaxy-root is not left with a different branch checked out on error.
Reasoning: - bettter separation of concerns - now we can test it
When updating packages, we always bump package version and update its history because the new-version argument is required (and it makes no sense to create a point release without a new version specified)
ahmedhamidawan
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor towards testability and readabililty: breakup large function, add misc. safeguards, tighten requirements, remove duplicate logic, other misc. refactoring, type hints.