Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor helm chart, splitting operator deps into separate chart #506

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

nuwang
Copy link
Member

@nuwang nuwang commented Nov 22, 2024

ToDo:

  • Should we version the two charts separately or together?
  • Should we bundle in the NFS chart with galaxy-deps for convenience? or disable the alien cache by default?

@nuwang nuwang added major refactoring code refactoring labels Nov 22, 2024
@afgane
Copy link
Contributor

afgane commented Nov 22, 2024

I feel separate versioning is better suited for us. The Galaxy chart is likely to advance much more frequently than the deps one as we tend to not seek latest features in most of our deps.

Bundling the NFS chart seems like a reasonable thing to do so all the deps are captured.

@nuwang
Copy link
Member Author

nuwang commented Nov 22, 2024

Versioning separately is ok, but we would have to make the bundling logic much more sophisticated. We would probably have to detect which subfolder changed, and then bump versions accordingly. There's also the complication of which chart a "minor/major" label applies to. Alternatively, we would need to maintain a separate repository. Maybe this is a separate thing that @ksuderman can help with, since he's done a lot of the packaging work.

@afgane
Copy link
Contributor

afgane commented Nov 22, 2024

Hmm, now I'm not so sure separate versioning is not worth it because the packaging seems like a bit of magic as is placing things a various places, which leads to playing pacman to find it all... But if we version it together, how will the upgrade process on a deployed instance look? Will all the deps get rotated every time?

@ksuderman
Copy link
Contributor

Would it be better to separate the galaxy-deps chart into its own repository and package/deploy it separately? That would clean up versioning and packaging issues.

@nuwang
Copy link
Member Author

nuwang commented Nov 22, 2024

Ok, I'll split it out into a new repository

@afgane
Copy link
Contributor

afgane commented Nov 22, 2024

I'd just suggest naming the repo (and the chart) galaxy-helm-deps so it is more clear that it applies to the Helm chart.

@nuwang nuwang removed the major label Nov 23, 2024
@nuwang
Copy link
Member Author

nuwang commented Nov 23, 2024

Removed versioning labels because we want to get all breaking changes into v6 in one go.

@nuwang nuwang changed the title [WIP] Refactor helm chart, splitting operator deps into separate chart Refactor helm chart, splitting operator deps into separate chart Nov 23, 2024
@nuwang
Copy link
Member Author

nuwang commented Nov 23, 2024

Deps moved to: https://github.com/galaxyproject/galaxy-helm-deps. I named the repo galaxy-helm-deps but the chart name remains as galaxy-deps to be consistent with the chart naming of galaxy.

Copy link
Contributor

@afgane afgane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this manually and installing the charts, running tools, and uninstalling the charts works as expected. Much more reliable than before!

@afgane afgane merged commit af84ee3 into master Nov 25, 2024
2 checks passed
@afgane afgane deleted the refactor_deps branch November 25, 2024 20:19
@afgane afgane restored the refactor_deps branch November 25, 2024 20:19
@afgane afgane deleted the refactor_deps branch November 25, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants