-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor helm chart, splitting operator deps into separate chart #506
Conversation
I feel separate versioning is better suited for us. The Galaxy chart is likely to advance much more frequently than the deps one as we tend to not seek latest features in most of our deps. Bundling the NFS chart seems like a reasonable thing to do so all the deps are captured. |
Versioning separately is ok, but we would have to make the bundling logic much more sophisticated. We would probably have to detect which subfolder changed, and then bump versions accordingly. There's also the complication of which chart a "minor/major" label applies to. Alternatively, we would need to maintain a separate repository. Maybe this is a separate thing that @ksuderman can help with, since he's done a lot of the packaging work. |
Hmm, now I'm not so sure separate versioning is |
Would it be better to separate the |
Ok, I'll split it out into a new repository |
I'd just suggest naming the repo (and the chart) |
Removed versioning labels because we want to get all breaking changes into v6 in one go. |
Deps moved to: https://github.com/galaxyproject/galaxy-helm-deps. I named the repo galaxy-helm-deps but the chart name remains as galaxy-deps to be consistent with the chart naming of galaxy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this manually and installing the charts, running tools, and uninstalling the charts works as expected. Much more reliable than before!
ToDo:
galaxy-deps
for convenience? or disable the alien cache by default?