chore: update dev dependancies #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hunterckx
requested changes
Dec 11, 2024
.eslintrc.json
Outdated
| @@ -57,7 +57,9 @@ | |||
| "jsdoc/require-returns-description": "error", | |||
| "jsdoc/check-alignment": "error", | |||
| "jsdoc/check-param-names": "error", | |||
| "react-hooks/exhaustive-deps": "error" | |||
| "react-hooks/exhaustive-deps": "error", | |||
| "@typescript-eslint/no-empty-object-type": "warn", | |||
There was a problem hiding this comment.
I think it might be worth leaving @typescript-eslint/no-empty-object-type at its default settings, and just removing the empty Props interface and its use as a type parameter in figure.styles.tsx -- as far as I can see there's no reason for that interface to exist, since the component is never passed any props anyway (though let me know if there's some particular reason to have this rule as a warning!)
There was a problem hiding this comment.
Thanks for catching this @hunterckx!
hunterckx
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
csv-parseseems to lead to the output being alphabetized