feat: rename genome list and update to use data from ncbi (#177) #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterckx
commented
Nov 17, 2024
|
|
||
|
|
||
| def add_gene_model_url(genomes_df: pd.DataFrame): | ||
| return pd.concat([genomes_df, genomes_df["accession"].apply(_id_to_gene_model_url).rename("geneModelUrl")], axis="columns") |
There was a problem hiding this comment.
I've added gene model URL -- not certain whether accession is appropriate for getting that
|
@hunterckx can you rebase this on main please? |
hunterckx
force-pushed
the
hunter/177-new-genomes-list
branch
from
37a5cef to
df266de
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags are not included because they're associated with organisms, not genomes-- Organisms are now includedThe UCSC Browser URLs of uncertain accuracy are still included-- I believe we've confirmed that our current matching method is accurate