Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dev build scripts (#13) #14

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

NoopDog
Copy link
Collaborator

@NoopDog NoopDog commented Aug 29, 2024

No description provided.

@NoopDog NoopDog requested a review from hunterckx August 29, 2024 21:07
Copy link
Collaborator

@hunterckx hunterckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When running a build locally, the npm start script no longer works -- seems like we need to do that a different way if we're using output: "export" (the error message says to use the serve package)
  • Another good thing for building locally would be to have out in the gitignore -- I seem to have gone a bit too minimal there (and with the prettierignore and eslintignore)
  • In the data catalog build script, there's a comment referencing AnVIL that should presumably be changed

Copy link
Collaborator

@hunterckx hunterckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hunterckx hunterckx merged commit 5799c9f into main Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants