fix: make isRef a string to avoid error when searching filters (#177)

galaxyproject · Dec 5, 2024 · 4541d15 · 4541d15
1 parent df266de
commit 4541d15
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 24 deletions.
diff --git a/app/apis/catalog/brc-analytics-catalog/common/entities.ts b/app/apis/catalog/brc-analytics-catalog/common/entities.ts
@@ -16,7 +16,7 @@ export interface BRCDataCatalogGenome {
   coverage: string | null;
   gcPercent: number;
   geneModelUrl: string | null;
-  isRef: boolean;
+  isRef: string;
   length: number;
   level: string;
   ncbiTaxonomyId: string;

diff --git a/app/viewModelBuilders/catalog/brc-analytics-catalog/common/viewModelBuilders.ts b/app/viewModelBuilders/catalog/brc-analytics-catalog/common/viewModelBuilders.ts
@@ -135,7 +135,7 @@ export const buildIsRef = (
   genome: BRCDataCatalogGenome
 ): ComponentProps<typeof C.BasicCell> => {
   return {
-    value: genome.isRef ? "Yes" : "No",
+    value: genome.isRef,
   };
 };
 

diff --git a/files/build-catalog.ts b/files/build-catalog.ts
@@ -106,6 +106,6 @@ function parseNumber(value: string): number {
   return n;
 }
 
-function parseBoolean(value: string): boolean {
-  return value[0].toLowerCase() === "t";
+function parseBoolean(value: string): string {
+  return value[0].toLowerCase() === "t" ? "Yes" : "No";
 }
diff --git a/files/out/genomes.json b/files/out/genomes.json
@@ -6,7 +6,7 @@
     "coverage": null,
     "gcPercent": 42.5,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/000/002/415/GCF_000002415.2/genes/GCF_000002415.2_ASM241v2.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 27007701,
     "level": "Chromosome",
     "ncbiTaxonomyId": "5855",
@@ -26,7 +26,7 @@
     "coverage": null,
     "gcPercent": 46.5,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/000/002/445/GCF_000002445.2/genes/GCF_000002445.2_ASM244v1.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 26075494,
     "level": "Chromosome",
     "ncbiTaxonomyId": "185431",
@@ -44,7 +44,7 @@
     "coverage": null,
     "gcPercent": 59.5,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/000/002/725/GCF_000002725.2/genes/GCF_000002725.2_ASM272v2.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 32855089,
     "level": "Complete Genome",
     "ncbiTaxonomyId": "347515",
@@ -62,7 +62,7 @@
     "coverage": "100.0x",
     "gcPercent": 19.5,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/000/002/765/GCF_000002765.6/genes/GCF_000002765.6_GCA_000002765.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 23292622,
     "level": "Complete Genome",
     "ncbiTaxonomyId": "36329",
@@ -80,7 +80,7 @@
     "coverage": null,
     "gcPercent": 58,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/000/002/845/GCF_000002845.2/genes/GCF_000002845.2_ASM284v2.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 32068771,
     "level": "Chromosome",
     "ncbiTaxonomyId": "420245",
@@ -98,7 +98,7 @@
     "coverage": "26.5x",
     "gcPercent": 52.5,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/000/006/565/GCF_000006565.2/genes/GCF_000006565.2_TGA4.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 65633124,
     "level": "Chromosome",
     "ncbiTaxonomyId": "508771",
@@ -116,7 +116,7 @@
     "coverage": null,
     "gcPercent": 46,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/000/149/335/GCF_000149335.2/genes/GCF_000149335.2_ASM14933v2.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 28947925,
     "level": "Scaffold",
     "ncbiTaxonomyId": "246410",
@@ -134,7 +134,7 @@
     "coverage": null,
     "gcPercent": 65.5,
     "geneModelUrl": null,
-    "isRef": true,
+    "isRef": "Yes",
     "length": 4411532,
     "level": "Complete Genome",
     "ncbiTaxonomyId": "83332",
@@ -152,7 +152,7 @@
     "coverage": null,
     "gcPercent": 51.5,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/000/209/065/GCF_000209065.1/genes/GCF_000209065.1_ASM20906v1.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 89937456,
     "level": "Scaffold",
     "ncbiTaxonomyId": "5693",
@@ -172,7 +172,7 @@
     "coverage": null,
     "gcPercent": 59.5,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/000/227/135/GCF_000227135.1/genes/GCF_000227135.1_ASM22713v2.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 32444968,
     "level": "Chromosome",
     "ncbiTaxonomyId": "5661",
@@ -192,7 +192,7 @@
     "coverage": null,
     "gcPercent": 65.5,
     "geneModelUrl": null,
-    "isRef": false,
+    "isRef": "No",
     "length": 4411709,
     "level": "Complete Genome",
     "ncbiTaxonomyId": "83332",
@@ -210,7 +210,7 @@
     "coverage": null,
     "gcPercent": 33,
     "geneModelUrl": null,
-    "isRef": false,
+    "isRef": "No",
     "length": 196858,
     "level": "Complete Genome",
     "ncbiTaxonomyId": "10244",
@@ -230,7 +230,7 @@
     "coverage": null,
     "gcPercent": 38,
     "geneModelUrl": null,
-    "isRef": false,
+    "isRef": "No",
     "length": 29903,
     "level": "Complete Genome",
     "ncbiTaxonomyId": "2697049",
@@ -250,7 +250,7 @@
     "coverage": "250.0x",
     "gcPercent": 37,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/016/801/865/GCF_016801865.2/genes/GCF_016801865.2_TS_CPP_V2.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 566339288,
     "level": "Chromosome",
     "ncbiTaxonomyId": "42434",
@@ -268,7 +268,7 @@
     "coverage": "475.0x",
     "gcPercent": 46.5,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/018/416/015/GCF_018416015.2/genes/GCF_018416015.2_ASM1841601v2.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 28193268,
     "level": "Complete Genome",
     "ncbiTaxonomyId": "443226",
@@ -286,7 +286,7 @@
     "coverage": "20.0x",
     "gcPercent": 65.5,
     "geneModelUrl": null,
-    "isRef": false,
+    "isRef": "No",
     "length": 4516435,
     "level": "Complete Genome",
     "ncbiTaxonomyId": "1773",
@@ -306,7 +306,7 @@
     "coverage": "100.0x",
     "gcPercent": 21.5,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/900/002/385/GCF_900002385.2/genes/GCF_900002385.2_GCA_900002385.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 23043114,
     "level": "Complete Genome",
     "ncbiTaxonomyId": "5861",
@@ -326,7 +326,7 @@
     "coverage": "155.0x",
     "gcPercent": 23,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/900/681/995/GCF_900681995.1/genes/GCF_900681995.1_PVVCY_v1.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 18338688,
     "level": "Complete Genome",
     "ncbiTaxonomyId": "54757",
@@ -344,7 +344,7 @@
     "coverage": "54.0x",
     "gcPercent": 44.5,
     "geneModelUrl": "https://hgdownload.soe.ucsc.edu/hubs/GCF/943/734/735/GCF_943734735.2/genes/GCF_943734735.2_idAnoGambNW_F1_1.ncbiRefSeq.gtf.gz",
-    "isRef": true,
+    "isRef": "Yes",
     "length": 264451381,
     "level": "Chromosome",
     "ncbiTaxonomyId": "7165",
@@ -364,7 +364,7 @@
     "coverage": "100.0x",
     "gcPercent": 65.5,
     "geneModelUrl": null,
-    "isRef": false,
+    "isRef": "No",
     "length": 4469156,
     "level": "Complete Genome",
     "ncbiTaxonomyId": "1773",