Fix docs for offset in get_histories and add test
#486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
changed the title
offset in get_histories and add test
|
Looks good @bernt-matthias. It improves the description of offset. |
bernt-matthias
force-pushed
the
doc_and_test_limit
branch
from
814103c to
dd1dacf
Compare
nsoranzo
reviewed
Jun 1, 2024
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
reviewed
Jun 1, 2024
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
approved these changes
Jun 1, 2024
I just forgot that it was in draft :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #484 ping @cat-bro