Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make themes structured data instead of read from file #219

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Aug 19, 2024

This way the role does not modify files in the playbook, and moves in line with other recent changes to move more of Galaxy's extraneous configs into structured data.

@mira-miracoli if you approve I'll update the documentation.

@natefoo natefoo requested a review from mira-miracoli August 19, 2024 16:17
@mira-miracoli
Copy link
Collaborator

cool, less files!
But the directory structure for the subdomain static files has to stay I guess?

@natefoo
Copy link
Member Author

natefoo commented Aug 20, 2024

Yes I think so since the same directory structure is used for the subdomain static files themselves.

@natefoo
Copy link
Member Author

natefoo commented Aug 20, 2024

In working on the documentation and defaults changes I noticed, I don't think we need the "default base domain" entry on the *_base_host config vars. For example, if you have:

themes_config_file: themes_conf.yml
themes_config_file_by_host:
  usegalaxy.eu: themes_conf.yml
  assembly.usegalaxy.eu: assembly.yml

Then the usegalaxy.eu entry is redundant since, if there is no matching hostname for usegalaxy.eu found in themes_config_file_by_host, it would fall back to the value of themes_config_file. So I removed this bit, but if I have this wrong and it doesn't work like I think it does, let me know.

@mira-miracoli
Copy link
Collaborator

I think it did not work without, but we can try :)

@natefoo
Copy link
Member Author

natefoo commented Aug 21, 2024

You're right, I have some additional hostnames set up for usegalaxy.org to reach my individual VMs directly (e.g. https://galaxy-web-05.galaxyproject.org/) and the themes aren't available via that route.

@natefoo natefoo merged commit 8ec9239 into main Aug 21, 2024
11 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants