Add GRAVITY_CONFIG_FILE to systemd env #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm that this passes the tests when running with |
|
More tests passing is a fantastic improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the reason why the molecule runs for version
23.0were failing was thatsupervisordwas attempting to run Galaxy with the wrong config file. On the failing containers,/srv/galaxy/var/gravity/supervisor/supervisord.conf.d/_default_.d/galaxy_gunicorn_gunicorn.confhas:It looks like this is because the systemd unit file doesn't correctly set the
GRAVITY_CONFIG_FILEenvironment variable.Additionally, I locally ran into some issues requiring further
aptdependencies to be installed on Ubuntu in order for some of Galaxy's dependencies to compile correctly. This does not seem to have lead to test failures on CI, my hunch is that this due to me using anARMbased machine locally, but I'm not sure. I've added the extraaptdependencies that I needed as they seem pretty sane, but feel free to chuck out that commit, of course :)