Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update best practice in README.md #211

Merged
merged 3 commits into from
Apr 16, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -425,16 +425,25 @@ Install Galaxy as per the current production server best practices:
become: yes
# Install with:
# % ansible-galaxy install natefoo.postgresql_objects
- role: natefoo.postgresql_objects
- role: galaxyproject.postgresql_objects
become: yes
become_user: postgres
- role: galaxyproject.galaxy
handlers:
- name: Restart Galaxy
supervisorctl:
name: galaxy
state: restarted
listen: restart galaxy
- name: Galaxy gravity restart
command: "/usr/local/bin/galaxyctl graceful"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
command: "/usr/local/bin/galaxyctl graceful"
command: "{{ galaxy_gravity_command }} graceful"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sadly doesn't work because galaxy_gravity_command is a default within the galaxy role, so it's not available in the playbook. But {{ galaxy_venv_dir }}/bin/galaxyctl might be a bit better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I knew I was using that based on seeing it from somewhere: the built in handlers We have two handlers defined, that call this already (handlers/gravity_23.0.yml)

So these handlers as defined in the example are no longer necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right! Those handlers weren't working for me, but I now see that may be due to #202 -- so probably that issue should be fixed, and the handlers should not be defined in the Readme. :)

listen: "restart galaxy"
post_tasks:

- name: Get Galaxy service Status
ansible.builtin.systemd:
name: "galaxy.target"
check_mode: true
register: galaxy_status

- name: Galaxy gravity start
command: "/usr/local/bin/galaxyctl start"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
command: "/usr/local/bin/galaxyctl start"
command: "{{ galaxy_gravity_command }} start"

when: "galaxy_status.status.ActiveState == 'inactive'"
```

License