-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update best practice in README.md #211
Merged
+14
−8
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -425,16 +425,25 @@ Install Galaxy as per the current production server best practices: | |||||
become: yes | ||||||
# Install with: | ||||||
# % ansible-galaxy install natefoo.postgresql_objects | ||||||
- role: natefoo.postgresql_objects | ||||||
- role: galaxyproject.postgresql_objects | ||||||
become: yes | ||||||
become_user: postgres | ||||||
- role: galaxyproject.galaxy | ||||||
handlers: | ||||||
- name: Restart Galaxy | ||||||
supervisorctl: | ||||||
name: galaxy | ||||||
state: restarted | ||||||
listen: restart galaxy | ||||||
- name: Galaxy gravity restart | ||||||
command: "/usr/local/bin/galaxyctl graceful" | ||||||
listen: "restart galaxy" | ||||||
post_tasks: | ||||||
|
||||||
- name: Get Galaxy service Status | ||||||
ansible.builtin.systemd: | ||||||
name: "galaxy.target" | ||||||
check_mode: true | ||||||
register: galaxy_status | ||||||
|
||||||
- name: Galaxy gravity start | ||||||
command: "/usr/local/bin/galaxyctl start" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
when: "galaxy_status.status.ActiveState == 'inactive'" | ||||||
``` | ||||||
|
||||||
License | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this sadly doesn't work because
galaxy_gravity_command
is a default within thegalaxy
role, so it's not available in the playbook. But{{ galaxy_venv_dir }}/bin/galaxyctl
might be a bit better?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I knew I was using that based on seeing it from somewhere: the built in handlers We have two handlers defined, that call this already (
handlers/gravity_23.0.yml
)So these handlers as defined in the example are no longer necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right! Those handlers weren't working for me, but I now see that may be due to #202 -- so probably that issue should be fixed, and the handlers should not be defined in the Readme. :)