Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore dropping CDSs #62

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Explore dropping CDSs #62

wants to merge 8 commits into from

Conversation

hexylena
Copy link
Member

perhaps we should hide this behind a flag?

right now it's written to drop every CDS, but the code allows to ignore CDS where the CDS location == exon location

not sure what to do with this :(

@abretaud
Copy link
Member

Woah, strange behavior in #60 indeed :/

Ok to merge something like this to fix things for most people, still need to see if we prefer the latest code suggestion in #60 (comment) (not much time to test it now :( )

@hexylena hexylena marked this pull request as ready for review January 31, 2024 10:23
@hexylena
Copy link
Member Author

oof

urllib3.connectionpool: DEBUG: http://localhost:8888 "POST /organism/findAllOrganisms HTTP/1.1" 200 None
root: INFO: Processing Merlin with features: [SeqFeature(SimpleLocation(ExactPosition(1), ExactPosition(691), strand=1), type='repeat_region', id='Merlin_800', qualifiers=...)]
root: DEBUG: type repeat_region
root: ERROR: Failed to load features from Merlin
root: DEBUG: writing out: []
root: DEBUG: empty list, no more features to write
root: DEBUG: writing out: []

not sure what to do about that. also not sure if it's due to fcd4ff9 (#62) where we started passing the parameters properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants