New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move setting of black hole seeds to a `nodeOperator` #757

Merged

abensonca merged 10 commits into master from featBlackHoleSeeds

Dec 15, 2024

Collaborator

abensonca commented Dec 13, 2024

This:

Moves physics out of the nodeComponentBlackHole class; and,
Allows for more flexibility in how black holes are seeded.

abensonca added 3 commits

December 13, 2024 08:56


          feat: Move setting of black hole seeds to a nodeOperator

085033d


          fix: Correct class description

76ccf82


          fix: Update parameter files to use new black hole seeding approach

1be440d

abensonca added components black holes labels

abensonca self-assigned this

github-actions bot commented Dec 13, 2024

⚠️ Possible misspelled word 'indepedent' in file 'source/black_holes.seeds.fixed.F90'
⚠️ Possible misspelled word 'indepedent' in file 'source/black_holes.seeds.fixed.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'
⚠️ Possible misspelled word 'existant' (2 instances) in file 'source/objects.nodes.components.black_hole.standard.F90'


          fix(style): Correct spelling

9f356a9

github-actions bot commented Dec 13, 2024

⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'


          fix: Correct parameter changes for black hole seeds

045b96c

github-actions bot commented Dec 14, 2024

⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'


          fix: Correct parameter names

1c9132a

github-actions bot commented Dec 14, 2024

⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'


          fix: Correct parameters

42123de

github-actions bot commented Dec 14, 2024

⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'

abensonca added 3 commits

December 14, 2024 19:58


          fix: Update launch script to use modern random number generator syntax

5eda1e0


          fix: Allow parameter migration test script to handle changes in the n…

e94a696

…umber of `nodeOperator`s


          fix: Mark new parameters as non-iterable

89436f0

github-actions bot commented Dec 15, 2024

⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'
⚠️ Possible misspelled word 'pre' in file 'source/nodes.operators.physics.star_formation.disks.F90'

abensonca added this pull request to the merge queue

Merged via the queue into master with commit 0c09c35

294 checks passed

abensonca deleted the featBlackHoleSeeds branch

December 15, 2024 18:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

black holes components