Improvements to the Radial Range that Subhalo Density Profiles are Tabulated when Fitting TNFW Profile

[cgannonucm]

Changed the range of radii at which the density profile is tabulated at when fitting TNFW profiles. Before the density was tabulated to the outer radius (where the radius encloses the bound mass or the total mass (of the subhalo), whichever is smaller). This definition led to the maximum radius taking on very large values in some cases. To fix this, the following changes have been implemented:

• Now the maximum tabulated radius is the virial radius if the outer radius is less than the virial radius
• If the outer radius is greater than the virial radius, the maximum radius is the radius at which the density drops to 1/10 the density at the virial radius or 10x the virial radius, whichever is smaller

[abensonca]

This was previously:

         do n=1,radiusMaxiumCountRadii
             radiusMaximum                     =10**(log10(radiusVirial)+step*dble(i))

So the loop variable was n but on the following line it used i to increment radiusMaximum. Most likely i=0 initially, so this would not have actually increased radiusMaximum, leaving it always equal to radiusVirial. I've corrected this (just using i as the loop variable), but it would be good if you can check if this still gives good results for the fits.

[cgannonucm]

I recompiled and re-ran the parameter with the bug fixed. The fits look good.

[abensonca]

Overall this looks good - I saw one issue with a difference between the name of a loop variable and the variable actually used in the loop (see other comment). I've fixed this, but let's check if the results still look good after this change.

[abensonca]

All tests have already passed, and since the fits still look good with the previous fix, this is ready to merge.