-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: declare parsers as optional peer dependencies #454
base: master
Are you sure you want to change the base?
Conversation
The parser is migrated to monorepo |
So better to not add any dependency to be compatible with both packages. Especially since there is no version restriction. |
@TrySound I wonder how Babel solved the peer dependency problem when moving from Babel 6 to 7. |
Which problem I don't follow? Babel-eslint bumped babel/core long time ago. |
@TrySound I remember there were lots of packages declaring unscoped Babel packages, e.g. One way I can think of is declaring both parser as optional using |
There was babel-core@7-bridge package which reexported |
@TrySound Now I remember, |
By @kaicataldo in babel/babel#11989 (comment)
I think declaring both of them as optional peer dependencies is the best way to go. |
The test shows
babel-eslint-plugin
is compatible with the latest of all major version ofbabel-eslint
, so*
is used.