Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing up Logic #27

Closed
wants to merge 1 commit into from
Closed

Fixing up Logic #27

wants to merge 1 commit into from

Conversation

esutley
Copy link

@esutley esutley commented Nov 21, 2024

What is this fixing or adding?

Fixes three logic errors (Kurt Zisa locations and Bear and Clock Puzzle) that could lead to unreachable locations, as well as some minor tweaks I had reported earlier

How was this tested?

Wonderland logic was tested on a generated game starting with required items and confirming the locations were/were not accessible then sending additional items to test.
Others were tested in previous games.

Fixes two logic errors (Kurt Zisa and Bear and Clock Puzzle) that could lead to unreachable locations, as well as some minor tweaks I had reported earlier
@esutley esutley requested a review from gaithern as a code owner November 21, 2024 19:44
@gaithern
Copy link

Hey this branch is kind of weirdly out of sync with main. I have been making new branches when I want to open PRs to main now, and it kind of made a mess haha. I opened up a new branch which I think I am going to use as the "KH1 Dev" branch now, https://github.com/gaithernOrg/ArchipelagoKH1FM. I added your logic changes there + the option changes I have open as a PR to main (keyblade stat shuffle + postcard and puppy options) + a small bugfix for client behavior. I'm going to run a game tonight to make sure everything is working, and if so, I'll make a new release on that page.

@gaithern gaithern closed this Nov 22, 2024
@esutley
Copy link
Author

esutley commented Nov 22, 2024

Gotcha, I wasn't sure about the branches and what would be the best to PR it too. This is Goblinpope/Goblin God btw, not Krujo!

@gaithern
Copy link

Man my fault haha, big day at work yesterday and I've got serious brain fog! Thanks for opening the PR though, its a lot easier than going through and making the changes myself :P

@esutley
Copy link
Author

esutley commented Nov 22, 2024

No worries! If I run into logic changes I'll PR them to the new branch. Gonna try and do an extra movement abilities run today and see if I catch anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants