IMAS 4.0.0 #327
Open
IMAS 4.0.0 #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have pushed a branch with v4.0.0 of the data dictionary. However transitioning to v4 requires some thought. For existing software, the use of
COCOS 17instead ofCOCOS 11is particularly problematic, and the change of_torto_phiis also very annoying.Beware that if you try to use this branch as it is, the
cocos.pyfile is not updated for v4.0.0 thanks to the_torto_phichange. Also all machine mappings will need to be reviewed and updated.One option going forward may be transition to
v4but add some automated translation between v3 and v4 within OMAS itself. OMAS automatic COCOS translationwith omas_environment(ods, cocosio=???):allow us to gracefully handle the COCOS 11 to 17 change. To avoid creeping of bugs we could change OMAS to raise an error if a quantity that is affected by the COCOS change gets accessed ouside of awith omas_environment. Then, all we need to do then is to handle_torto_phitranslations, which would be doable.Anyways, before rushing to make in any such update, I'd like to wait and see how quickly the IMAS ecosystem adapts to the v4 changes.