Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mf_All.js removed _id #235

Closed
1u opened this issue Jun 1, 2016 · 2 comments
Closed

mf_All.js removed _id #235

1u opened this issue Jun 1, 2016 · 2 comments

Comments

@1u
Copy link
Contributor

1u commented Jun 1, 2016

id is removed in mfAll.js. but linked object with this same id remains in collection.
randomly searching, sorry... (tell me if it's annoying :)

same commit: (Openki/Openki@f2f9e67)

     "course.edit.groupUnlistingError": {
-      "_id": "CT4xcjqjH7ZdScT5Y",
       "key": "course.edit.groupUnlistingError",
       "lang": "en",
       "text": "Unable to remove group: {ERROR}",
-      "ctime": "2015-10-14T17:05:17.000Z",
-      "mtime": "2015-10-14T17:05:17.000Z",
-      "revisionId": "KjxRu8DK8f3xLMAB8",
-      "file": "client/views/groups/groupListing.js",
-      "line": 37,
-      "func": "function(err)"
+      "ctime": 1464642609000,
+      "mtime": 1464704870979,
+      "revisionId": "LE4kssXimP2ZyS7hn",
+      "file": "client/views/groups/listing/groupListing.js",
+      "line": 38,
+      "template": "unknown",
+      "removed": true
+    },

why is it removed and what happens if key is added again?

@gadicc
Copy link
Owner

gadicc commented Jun 6, 2016

Yeah, this is correct; we no longer rely on the _id for uniqueness, rather the combination of key and lang. This makes it a lot easier to sync between dev and production where the _id might be different.

@gadicc
Copy link
Owner

gadicc commented Jun 6, 2016

Let me track this with the order in #233.

@gadicc gadicc closed this as completed Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants