Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mfAll.js - order switched without other change in object #233

Open
1u opened this issue Jun 1, 2016 · 2 comments
Open

mfAll.js - order switched without other change in object #233

1u opened this issue Jun 1, 2016 · 2 comments
Milestone

Comments

@1u
Copy link
Contributor

1u commented Jun 1, 2016

here's a part of our commit (Openki/Openki@f2f9e67) where we added new mfAll.js file:

@@ -12696,8 +12704,8 @@ mfPkg.syncAll({
       "ctime": 1448105916866,
       "mtime": 1448105916866,
       "revisionId": "HGFTwQLQXhRZCkzjp",
-      "fuzzy": true,
-      "removed": true
+      "removed": true,
+      "fuzzy": true
@1u
Copy link
Contributor Author

1u commented Jun 4, 2016

and with other changes...

     "roles.mentor.description": {
-      "_id": "xdHJGjxqS8fw5EMWn",
       "key": "roles.mentor.description",
       "lang": "el",
-      "text": "ένας μέντορας",
+      "text": "ένα μέντορας",
       "ctime": 1448107474176,
-      "mtime": 1448107474176,
-      "revisionId": "Jzr8w9Ba9DfbtesuK"
+      "mtime": 1464988101526,
+      "revisionId": "TKTakSQKCXTwG5Hhs",
+      "_id": "xdHJGjxqS8fw5EMWn"
     },

@gadicc
Copy link
Owner

gadicc commented Jun 6, 2016

Ok, yes, we should be consistent about always skipping the _id now (#235) and we short sort sub keys by fixed order too (or just alphabetically).

@gadicc gadicc added this to the v2 milestone Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants