Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the images for every compendium entry of totk with the following properties, as discussed in #30 (comment) :
There is one possible issue I could already spot:
The
image:
value of weapons that end with(new)
are missing an underscore right before (should be_(new)
)!This seems to be because the same is true for the names of these items. So for example the entry
gerudo_scimitar (new)
is missing an underscore aswell (should begerudo_scimitar_(new)
).Edit: It's actually all entries that have more than one space in the name, see my reply below.
https://botw-compendium.herokuapp.com/api/v3/compendium/entry/gerudo_scimitar (new)/image?game=totk
It would be very easy to change the filenames of these couple images, but it's probably best to correct the entries' names. Unless this is on purpose.
See image: