Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for secrets in BuildxCLI to show that they are optional #651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tests for secrets in BuildxCLI to show that they are optional #651

wants to merge 1 commit into from

Conversation

Felixoid
Copy link

This PR should fix #609

gabrieldemarmiesse
gabrieldemarmiesse approved these changes Nov 19, 2024
View reviewed changes
Copy link
Owner

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the fix! Can you add a unit test which wouldn't work without this fix?

@Felixoid
Copy link
Author

Done. Didn't see them before the CI launched

@Felixoid
Copy link
Author

You know, if I remove the patch of BuildxCLI, it will still work. I think your code add_args_iterable_or_single is already very good, so I'd just add the test, and it's good to go.

@Felixoid Felixoid changed the title Make secrets optional for BuildxCLI Add tests for secrets in BuildxCLI to show that they are optional Nov 19, 2024
@gabrieldemarmiesse
Copy link
Owner

Yes, maybe I misunderstood the bug report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buildx CLI shouldn't require secrets
2 participants
@Felixoid @gabrieldemarmiesse