subtypes for charts

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java

@@ -1431,6 +1431,10 @@ private void configureChartResolvers(final RuntimeWiring.Builder builder) {
             .dataFetcher("statsSummary", new ChartStatsSummaryResolver(this.timeseriesAspectService))
             .dataFetcher("privileges", new EntityPrivilegesResolver(entityClient))
             .dataFetcher("exists", new EntityExistsResolver(entityService))
+            .dataFetcher("subTypes", new SubTypesResolver(
+                this.entityClient,
+                "chart",
+                "subTypes"))
         );
         builder.type("ChartInfo", typeWiring -> typeWiring
             .dataFetcher("inputs", new LoadableTypeBatchResolver<>(datasetType,

datahub-graphql-core/src/main/resources/entity.graphql

@@ -5239,6 +5239,11 @@ type Chart implements EntityWithRelationships & Entity & BrowsableEntity {
     Whether or not this entity exists on DataHub
     """
     exists: Boolean
+
+    """
+    Sub Types that this entity implements
+    """
+    subTypes: SubTypes
 }
 
 """

datahub-web-react/lineage_fix.patch

@@ -0,0 +1,40 @@
+diff --git a/datahub-web-react/src/app/lineage/utils/layoutTree.ts b/datahub-web-react/src/app/lineage/utils/layoutTree.ts
+index cc70400704..4d34103b9d 100644
+--- a/datahub-web-react/src/app/lineage/utils/layoutTree.ts
++++ b/datahub-web-react/src/app/lineage/utils/layoutTree.ts
+@@ -32,6 +32,20 @@ function getParentRelationship(direction: Direction, parent: VizNode | null, nod
+     return directionRelationships?.find((r) => r?.entity?.urn === node?.urn);
+ }
+
++function firstAppearanceIndices(arr) {
++    const seen = new Set(); // To track which strings have been seen
++    const result = [] as number[];
++
++    for (let i = 0; i < arr.length; i++) {
++        if (!seen.has(arr[i])) {
++            seen.add(arr[i]); // Add the string to the set
++            result.push(i); // Save the index
++        }
++    }
++
++    return result;
++}
++
+ function layoutNodesForOneDirection(
+     data: NodeData,
+     direction: Direction,
+@@ -54,12 +68,10 @@ function layoutNodesForOneDirection(
+     while (nodesInCurrentLayer.length > 0) {
+         // if we've already added a node to the viz higher up dont add it again
+         const urnsToAddInCurrentLayer = Array.from(new Set(nodesInCurrentLayer.map(({ node }) => node.urn || '')));
+-        const nodesToAddInCurrentLayer = urnsToAddInCurrentLayer
+-            .filter((urn, pos) => urnsToAddInCurrentLayer.indexOf(urn) === pos)
+-            .filter((urn) => !nodesByUrn[urn || '']);
++        const positionsToAddInCurrentLayer = firstAppearanceIndices(urnsToAddInCurrentLayer);
+
+         const filteredNodesInCurrentLayer = nodesInCurrentLayer
+-            .filter(({ node }) => nodesToAddInCurrentLayer.indexOf(node.urn || '') > -1)
++            .filter((_, idx) => positionsToAddInCurrentLayer.indexOf(idx) > -1)
+             .filter(({ node }) => node.status?.removed !== true);
+
+         const layerSize = filteredNodesInCurrentLayer.length;

datahub-web-react/src/app/entity/chart/ChartEntity.tsx

@@ -154,10 +154,12 @@ export class ChartEntity implements Entity<Chart> {
     getOverridePropertiesFromEntity = (chart?: Chart | null): GenericEntityProperties => {
         // TODO: Get rid of this once we have correctly formed platform coming back.
         const name = chart?.properties?.name;
+        const subTypes = chart?.subTypes;
         const externalUrl = chart?.properties?.externalUrl;
         return {
             name,
             externalUrl,
+            entityTypeOverride: subTypes ? capitalizeFirstLetterOnly(subTypes.typeNames?.[0]) : '',
         };
     };
 
@@ -187,6 +189,7 @@ export class ChartEntity implements Entity<Chart> {
         return (
             <ChartPreview
                 urn={data.urn}
+                subType={data.subTypes?.typeNames?.[0]}
                 platform={data?.platform?.properties?.displayName || capitalizeFirstLetterOnly(data?.platform?.name)}
                 platformInstanceId={data.dataPlatformInstance?.instanceId}
                 name={data.properties?.name}
@@ -222,6 +225,7 @@ export class ChartEntity implements Entity<Chart> {
             type: EntityType.Chart,
             icon: entity?.platform?.properties?.logoUrl || undefined,
             platform: entity?.platform,
+            subtype: entity?.subTypes?.typeNames?.[0] || undefined,
         };
     };
 

datahub-web-react/src/app/entity/chart/preview/ChartPreview.tsx

@@ -15,6 +15,7 @@ import {
     EntityPath,
 } from '../../../../types.generated';
 import DefaultPreviewCard from '../../../preview/DefaultPreviewCard';
+import { capitalizeFirstLetterOnly } from '../../../shared/textUtil';
 import { useEntityRegistry } from '../../../useEntityRegistry';
 import { IconStyleType } from '../../Entity';
 import { ChartStatsSummary as ChartStatsSummaryView } from '../shared/ChartStatsSummary';
@@ -43,6 +44,7 @@ export const ChartPreview = ({
     snippet,
     degree,
     paths,
+    subType,
 }: {
     urn: string;
     platform?: string;
@@ -67,6 +69,7 @@ export const ChartPreview = ({
     snippet?: React.ReactNode | null;
     degree?: number;
     paths?: EntityPath[];
+    subType?: string | null;
 }): JSX.Element => {
     const entityRegistry = useEntityRegistry();
 
@@ -76,7 +79,7 @@ export const ChartPreview = ({
             name={name || ''}
             urn={urn}
             description={description || ''}
-            type="Chart"
+            type={capitalizeFirstLetterOnly(subType) || 'Chart'}
             typeIcon={entityRegistry.getIcon(EntityType.Chart, 14, IconStyleType.ACCENT)}
             logoUrl={logoUrl || ''}
             platform={platform}

datahub-web-react/src/graphql/chart.graphql

@@ -100,6 +100,9 @@ query getChart($urn: String!) {
             canEditLineage
             canEditEmbed
         }
+        subTypes {
+            typeNames
+        }
     }
 }
 

datahub-web-react/src/graphql/lineage.graphql

@@ -165,6 +165,9 @@ fragment lineageNodeProperties on EntityWithRelationships {
         status {
             removed
         }
+        subTypes {
+            typeNames
+        }
     }
     ... on Dataset {
         name

datahub-web-react/src/graphql/search.graphql

@@ -105,6 +105,9 @@ fragment autoCompleteFields on Entity {
         parentContainers {
             ...parentContainersFields
         }
+        subTypes {
+            typeNames
+        }
     }
     ... on DataFlow {
         orchestrator
@@ -550,6 +553,9 @@ fragment searchResultFields on Entity {
                 }
             }
         }
+        subTypes {
+            typeNames
+        }
     }
     ... on DataFlow {
         flowId

metadata-models/src/main/resources/entity-registry.yml

@@ -120,6 +120,7 @@ entities:
       - globalTags
       - glossaryTerms
       - browsePathsV2
+      - subTypes
   - name: dashboard
     keyAspect: dashboardKey
     aspects: