Skip to content
This repository has been archived by the owner on Jan 24, 2018. It is now read-only.

Protobuf 3.2.0 #1634

Closed
wants to merge 6 commits into from
Closed

Protobuf 3.2.0 #1634

wants to merge 6 commits into from

Conversation

ljdursi
Copy link

@ljdursi ljdursi commented Mar 29, 2017

Bumps protobuf version to 3.2.0, which means C++ implementation on Linux and so faster/reduced memory usage. Addresses issue #1623.

The C++ implementation is fussier than the python version - this means that pythonic things like conversion between string types doesn't happen automatically, so that strings passed to protobuf routines have to be byte strings, not unicode strings. Floating point comparisons are done at float32 precision.

Copy link
Member

@david4096 david4096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates requirements and tests, +1 thanks!

@ljdursi ljdursi closed this Nov 17, 2017
@ljdursi ljdursi deleted the protobuf_3.2.0 branch November 17, 2017 02:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants