Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(obs): add obs resources support #165

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feat(obs): add obs resources support #165

merged 1 commit into from
Dec 28, 2023

Conversation

Zhukun-Huawei
Copy link
Contributor

@Zhukun-Huawei Zhukun-Huawei commented Nov 24, 2023 •
edited
Loading

What this PR does / why we need it:
transfer obs resource from HuaweiCloud Provider to G42Cloud Provider
Which issue this PR fixes:
import obs resource, unit tests and docs

Special notes for your reviewer:

Release note:

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

=== RUN   TestAccOBSBucketAcl_basic
=== PAUSE TestAccOBSBucketAcl_basic
=== CONT  TestAccOBSBucketAcl_basic
--- PASS: TestAccOBSBucketAcl_basic (81.70s)
PASS
coverage: 11.2% of statements in ../../../../../terraform-provider-g42cloud/...

=== RUN   TestAccOBSBucketObjectAcl_basic
=== PAUSE TestAccOBSBucketObjectAcl_basic
=== CONT  TestAccOBSBucketObjectAcl_basic
--- PASS: TestAccOBSBucketObjectAcl_basic (82.19s)
PASS

coverage: 11.2% of statements in ../../../../../terraform-provider-g42cloud/...

=== RUN   TestAccOBSBucketObjectAcl_checkError
=== PAUSE TestAccOBSBucketObjectAcl_checkError
=== CONT  TestAccOBSBucketObjectAcl_checkError
--- PASS: TestAccOBSBucketObjectAcl_checkError (25.32s)
PASS

coverage: 9.0% of statements in ../../../../../terraform-provider-g42cloud/...

@github-ci-robot
Copy link
Collaborator

PR needs rebase.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 1, 2023
@Zhukun-Huawei Zhukun-Huawei force-pushed the obs_branch branch 2 times, most recently from de13080 to 4ad8690 Compare December 4, 2023 03:37
@Zippo-Wang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added LGTM "Looks good to me", indicates that a PR is ready to be merged. needs-rebase labels Dec 4, 2023
@github-ci-robot
Copy link
Collaborator

PR needs rebase.

@github-ci-robot github-ci-robot removed LGTM "Looks good to me", indicates that a PR is ready to be merged. needs-rebase labels Dec 12, 2023
@Zippo-Wang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@chengxiangdong
Copy link
Collaborator

/retitle feat(obs): add obs resources support

@github-ci-robot github-ci-robot changed the title feat(obs): import obs resource, unit tests and docs feat(obs): add obs resources support Dec 28, 2023
@github-ci-robot github-ci-robot added needs-rebase and removed LGTM "Looks good to me", indicates that a PR is ready to be merged. labels Dec 28, 2023
@github-ci-robot
Copy link
Collaborator

PR needs rebase.

@Zhukun-Huawei Zhukun-Huawei force-pushed the obs_branch branch 2 times, most recently from 6ddccb3 to db01f8f Compare December 28, 2023 08:16
@chengxiangdong chengxiangdong merged commit 88d3464 into g42cloud-terraform:main Dec 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zhukun-Huawei @github-ci-robot @Zippo-Wang @chengxiangdong