Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(EIP): add EIP resource and data sources #161

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feat(EIP): add EIP resource and data sources #161

merged 1 commit into from
Dec 28, 2023

Conversation

Zhukun-Huawei
Copy link
Contributor

@Zhukun-Huawei Zhukun-Huawei commented Nov 22, 2023 •
edited
Loading

What this PR does / why we need it:
transfer eip resource from HuaweiCloud to G42Cloud
Which issue this PR fixes:
import eip resource, unit tests and docs

Release note:

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

=== RUN   TestAccBandWidthAssociate_migrate
=== PAUSE TestAccBandWidthAssociate_migrate
=== CONT  TestAccBandWidthAssociate_migrate
--- PASS: TestAccBandWidthAssociate_migrate (91.76s)
PASS
coverage: 11.2% of statements in ../../../../../terraform-provider-g42cloud/...

=== RUN   TestAccBandWidthAssociate_basic
=== PAUSE TestAccBandWidthAssociate_basic
=== CONT  TestAccBandWidthAssociate_basic
--- PASS: TestAccBandWidthAssociate_basic (70.29s)
PASS

coverage: 11.2% of statements in ../../../../../terraform-provider-g42cloud/...

@github-ci-robot
Copy link
Collaborator

PR needs rebase.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 1, 2023
@Zippo-Wang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2023
@github-ci-robot github-ci-robot removed the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023
@Zhukun-Huawei Zhukun-Huawei force-pushed the eip_branch branch 6 times, most recently from f0f6130 to 4805105 Compare December 12, 2023 08:17
@github-ci-robot
Copy link
Collaborator

PR needs rebase.

@Zippo-Wang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@chengxiangdong
Copy link
Collaborator

/retitle feat(EIP): add EIP resource and data sources

@github-ci-robot github-ci-robot changed the title feat(eip): import eip resource, unit tests and docs feat(EIP): add EIP resource and data sources Dec 28, 2023
@chengxiangdong chengxiangdong merged commit cf40ffa into g42cloud-terraform:main Dec 28, 2023
6 checks passed
@github-ci-robot github-ci-robot removed the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zhukun-Huawei @github-ci-robot @Zippo-Wang @chengxiangdong