feat(dms): import dms resource, unit tests and docs #159

Zhukun-Huawei · 2023-11-22T04:05:53Z

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

Tests added/passed.
Documentation updated.
Schema updated.

Acceptance Steps Performed

make testacc TEST='./g42cloud' TESTARGS='-run=TestAccSomethingV0_basic'
...
=== RUN   TestAccSomethingV0_basic
--- PASS: TestAccSomethingV0_basic (70.75s)
PASS
ok      github.com/g42cloud-terraform/terraform-provider-g42cloud/g42cloud       70.796s

github-ci-robot · 2023-11-28T05:56:56Z

PR needs rebase.

github-actions · 2023-12-01T03:23:39Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-12-01T09:53:10Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-12-01T09:56:36Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-12-04T09:23:29Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-12-04T09:41:19Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-12-04T11:23:41Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-12-04T11:25:26Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Zippo-Wang · 2023-12-04T12:31:03Z

/lgtm

chengxiangdong · 2023-12-12T01:17:32Z

docs/data-sources/dms_rabbitmq_flavors.md

+* `charging_mode` - (Optional, String) Specifies the flavor billing mode.
+  The valid values are **prePaid** and **postPaid**.


The billing modes are all postPaid and this field is not required.

done, fix it

chengxiangdong · 2023-12-12T01:17:38Z

docs/data-sources/dms_rabbitmq_flavors.md

+
+* `arch_types` - Indicates the list of supported CPU architectures.
+
+* `charging_modes` - Indicates the list of supported billing modes.


done, fix it

chengxiangdong · 2023-12-12T01:17:54Z

g42cloud/services/acceptance/dms/data_source_g42cloud_dms_rabbitmq_flavors_test.go

+data "g42cloud_dms_rabbitmq_flavors" "test" {
+  type               = local.test_refer.type
+  arch_type          = local.test_refer.arch_types[0]
+  charging_mode      = local.test_refer.charging_modes[0]


done, fix it

github-actions · 2023-12-12T06:48:02Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-12-12T06:48:56Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-12-12T11:16:37Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-12-12T11:20:46Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-12-12T12:03:04Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-12-12T12:06:42Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Zippo-Wang · 2023-12-14T02:39:19Z

/lgtm

github-ci-robot added the needs-rebase label Nov 28, 2023

Zhukun-Huawei force-pushed the dms_branch branch from a2a5b55 to 0a44f54 Compare December 1, 2023 03:23

github-ci-robot removed the needs-rebase label Dec 1, 2023

github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 1, 2023

Zhukun-Huawei force-pushed the dms_branch branch from 0a44f54 to be7bc46 Compare December 1, 2023 09:52

Zhukun-Huawei force-pushed the dms_branch branch from be7bc46 to 913a648 Compare December 1, 2023 09:56

Zhukun-Huawei force-pushed the dms_branch branch from 913a648 to df88203 Compare December 4, 2023 09:23

Zhukun-Huawei force-pushed the dms_branch branch from df88203 to 73dc84d Compare December 4, 2023 09:41

Zhukun-Huawei force-pushed the dms_branch branch from 73dc84d to 9c46aa7 Compare December 4, 2023 11:23

Zhukun-Huawei force-pushed the dms_branch branch from 9c46aa7 to 373cc63 Compare December 4, 2023 11:25

github-ci-robot added the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2023

chengxiangdong reviewed Dec 12, 2023

View reviewed changes

Zhukun-Huawei force-pushed the dms_branch branch from 373cc63 to e6db7f7 Compare December 12, 2023 06:47

github-ci-robot removed the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023

Zhukun-Huawei force-pushed the dms_branch branch from e6db7f7 to 98c9b68 Compare December 12, 2023 06:48

Zhukun-Huawei force-pushed the dms_branch branch from 98c9b68 to 4ad06f7 Compare December 12, 2023 11:16

Zhukun-Huawei force-pushed the dms_branch branch from 4ad06f7 to 541907b Compare December 12, 2023 11:20

Zhukun-Huawei force-pushed the dms_branch branch from 541907b to 2365fdd Compare December 12, 2023 12:02

feat(dms): import dms resource

8e2deb5

Zhukun-Huawei force-pushed the dms_branch branch from 2365fdd to 8e2deb5 Compare December 12, 2023 12:06

github-ci-robot added the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023

chengxiangdong merged commit e1aa8cd into g42cloud-terraform:main Dec 28, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dms): import dms resource, unit tests and docs #159

feat(dms): import dms resource, unit tests and docs #159

Zhukun-Huawei commented Nov 22, 2023 •

edited

Loading

github-ci-robot commented Nov 28, 2023

github-actions bot commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

github-actions bot commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

Zippo-Wang commented Dec 4, 2023

chengxiangdong Dec 12, 2023

Zhukun-Huawei Dec 12, 2023

chengxiangdong Dec 12, 2023

Zhukun-Huawei Dec 12, 2023

chengxiangdong Dec 12, 2023

Zhukun-Huawei Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

Zippo-Wang commented Dec 14, 2023

		* `charging_mode` - (Optional, String) Specifies the flavor billing mode.
		The valid values are prePaid and postPaid.


		* `arch_types` - Indicates the list of supported CPU architectures.

		* `charging_modes` - Indicates the list of supported billing modes.

feat(dms): import dms resource, unit tests and docs #159

feat(dms): import dms resource, unit tests and docs #159

Conversation

Zhukun-Huawei commented Nov 22, 2023 • edited Loading

PR Checklist

Acceptance Steps Performed

github-ci-robot commented Nov 28, 2023

github-actions bot commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

github-actions bot commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

Zippo-Wang commented Dec 4, 2023

chengxiangdong Dec 12, 2023

Choose a reason for hiding this comment

Zhukun-Huawei Dec 12, 2023

Choose a reason for hiding this comment

chengxiangdong Dec 12, 2023

Choose a reason for hiding this comment

Zhukun-Huawei Dec 12, 2023

Choose a reason for hiding this comment

chengxiangdong Dec 12, 2023

Choose a reason for hiding this comment

Zhukun-Huawei Dec 12, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

Zippo-Wang commented Dec 14, 2023

Zhukun-Huawei commented Nov 22, 2023 •

edited

Loading