Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DEW): add a DataSource to query the CSMS secret #158

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Zippo-Wang
Copy link
Contributor

@Zippo-Wang Zippo-Wang commented Nov 21, 2023

What this PR does / why we need it:
import DEW resource, unit test and document.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

=== RUN   TestAccDewCsmsSecretVersion_basic
=== PAUSE TestAccDewCsmsSecretVersion_basic
=== CONT  TestAccDewCsmsSecretVersion_basic
--- PASS: TestAccDewCsmsSecretVersion_basic (48.92s)
PASS

coverage: 8.2% of statements in ../../../../../terraform-provider-g42cloud/...

@github-ci-robot
Copy link
Collaborator

PR needs rebase.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 30, 2023
@chengxiangdong
Copy link
Collaborator

/retitle feat(DEW): add a DataSource to query the CSMS secret

@github-ci-robot github-ci-robot changed the title feat(DEW): import DEW resource, unit test and document. feat(DEW): add a DataSource to query the CSMS secret Dec 1, 2023
@chengxiangdong
Copy link
Collaborator

/lgtm
/approve

@github-ci-robot github-ci-robot added the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2023
@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@github-ci-robot github-ci-robot merged commit a4d2da6 into g42cloud-terraform:main Dec 1, 2023
6 checks passed
@Zippo-Wang Zippo-Wang deleted the migrate_DEW branch December 1, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants