feat(DDS): import DDS resource, unit test and document #151

Zippo-Wang · 2023-11-16T08:18:50Z

What this PR does / why we need it:
import CSS resource, unit test and document

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

Tests added/passed.
Documentation updated.
Schema updated.

Acceptance Steps Performed

### data_source_g42cloud_dds_instances

=== RUN   TestAccDatasourceDdsInstance_basic
=== PAUSE TestAccDatasourceDdsInstance_basic
=== CONT  TestAccDatasourceDdsInstance_basic
--- PASS: TestAccDatasourceDdsInstance_basic (888.87s)
PASS
coverage: 8.6% of statements in ../../../../../terraform-provider-g42cloud/...

### resource_g42cloud_dds_backup

=== RUN   TestAccDdsBackup_basic
=== PAUSE TestAccDdsBackup_basic
=== CONT  TestAccDdsBackup_basic
--- PASS: TestAccDdsBackup_basic (1186.65s)
PASS

coverage: 14.7% of statements in ../../../../../terraform-provider-g42cloud/...


### resource_g42cloud_dds_parameter_template

=== RUN   TestAccDdsParameterTemplate_basic
=== PAUSE TestAccDdsParameterTemplate_basic
=== CONT  TestAccDdsParameterTemplate_basic
--- PASS: TestAccDdsParameterTemplate_basic (71.84s)
PASS

coverage: 11.1% of statements in ../../../../../terraform-provider-g42cloud/...


=== RUN   TestDdsParameterTemplate_shared_basic
=== PAUSE TestDdsParameterTemplate_shared_basic
=== CONT  TestDdsParameterTemplate_shared_basic
--- PASS: TestDdsParameterTemplate_shared_basic (40.75s)
PASS

coverage: 11.1% of statements in ../../../../../terraform-provider-g42cloud/...


=== RUN   TestDdsParameterTemplate_config_basic
=== PAUSE TestDdsParameterTemplate_config_basic
=== CONT  TestDdsParameterTemplate_config_basic
--- PASS: TestDdsParameterTemplate_config_basic (55.69s)
PASS

coverage: 11.1% of statements in ../../../../../terraform-provider-g42cloud/...

=== RUN   TestDdsParameterTemplate_replica_basic
=== PAUSE TestDdsParameterTemplate_replica_basic
=== CONT  TestDdsParameterTemplate_replica_basic
--- PASS: TestDdsParameterTemplate_replica_basic (26.33s)
PASS

coverage: 11.1% of statements in ../../../../../terraform-provider-g42cloud/...


### resource_g42cloud_database_role

=== RUN   TestAccDatabaseRole_basic
=== PAUSE TestAccDatabaseRole_basic
=== CONT  TestAccDatabaseRole_basic
--- PASS: TestAccDatabaseRole_basic (1032.62s)
PASS

coverage: 11.6% of statements in ../../../../../terraform-provider-g42cloud/...


### resource_g42cloud_database_user

=== RUN   TestAccDatabaseUser_basic
=== PAUSE TestAccDatabaseUser_basic
=== CONT  TestAccDatabaseUser_basic
--- PASS: TestAccDatabaseUser_basic (864.56s)
PASS

coverage: 11.6% of statements in ../../../../../terraform-provider-g42cloud/...


### resource_g42cloud_audit_log_policy

=== RUN   TestAccDdsAuditLogPolicy_basic
=== PAUSE TestAccDdsAuditLogPolicy_basic
=== CONT  TestAccDdsAuditLogPolicy_basic
--- PASS: TestAccDdsAuditLogPolicy_basic (898.02s)
PASS

coverage: 11.6% of statements in ../../../../../terraform-provider-g42cloud/...

github-ci-robot · 2023-11-28T05:56:56Z

PR needs rebase.

github-ci-robot · 2023-11-29T06:17:53Z

PR needs rebase.

github-actions · 2023-11-30T09:41:54Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-ci-robot · 2023-12-01T03:16:42Z

PR needs rebase.

github-actions · 2023-12-01T03:19:48Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Zhukun-Huawei · 2023-12-08T07:36:15Z

g42cloud/provider.go

@@ -219,7 +219,8 @@ func Provider() *schema.Provider {
 			"g42cloud_ddm_engines": ddm.DataSourceDdmEngines(),
 			"g42cloud_ddm_flavors": ddm.DataSourceDdmFlavors(),

-			"g42cloud_dds_flavors": dds.DataSourceDDSFlavorV3(),
+			"g42cloud_dds_flavors":   dds.DataSourceDDSFlavorV3(),


the num of resources/data sources added in provider.go are less than the num of actual newly added ut/doc files, pls check

github-actions · 2023-12-08T08:36:01Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Zhukun-Huawei · 2023-12-08T08:42:59Z

/lgtm

chengxiangdong · 2023-12-12T01:14:19Z

/approve

github-ci-robot added the needs-rebase label Nov 28, 2023

Zippo-Wang force-pushed the migrate_DDS branch from 2b54fee to 4caa53e Compare November 28, 2023 07:40

github-ci-robot added needs-rebase and removed needs-rebase labels Nov 28, 2023

github-actions bot added the feature label Nov 29, 2023

github-ci-robot added needs-rebase and removed needs-rebase labels Nov 29, 2023

chengxiangdong force-pushed the main branch from c24166b to df09970 Compare November 30, 2023 09:27

Zippo-Wang force-pushed the migrate_DDS branch from 4caa53e to d50a02c Compare November 30, 2023 09:41

github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 30, 2023

github-ci-robot added the needs-rebase label Dec 1, 2023

Zippo-Wang force-pushed the migrate_DDS branch from d50a02c to 4ef7982 Compare December 1, 2023 03:19

github-ci-robot removed the needs-rebase label Dec 1, 2023

Zhukun-Huawei reviewed Dec 8, 2023

View reviewed changes

feat(DDS): import DDS resource, unit test and document

2cc77f7

Zippo-Wang force-pushed the migrate_DDS branch from 4ef7982 to 2cc77f7 Compare December 8, 2023 08:35

github-ci-robot added the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2023

github-ci-robot approved these changes Dec 12, 2023

View reviewed changes

github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023

github-ci-robot merged commit 7c85a5e into g42cloud-terraform:main Dec 12, 2023
4 checks passed

Zippo-Wang deleted the migrate_DDS branch December 28, 2023 08:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(DDS): import DDS resource, unit test and document #151

feat(DDS): import DDS resource, unit test and document #151

Zippo-Wang commented Nov 16, 2023 •

edited

Loading

github-ci-robot commented Nov 28, 2023

github-ci-robot commented Nov 29, 2023

github-actions bot commented Nov 30, 2023

github-ci-robot commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

Zhukun-Huawei Dec 8, 2023 •

edited

Loading

Zippo-Wang Dec 8, 2023

github-actions bot commented Dec 8, 2023

Zhukun-Huawei commented Dec 8, 2023

chengxiangdong commented Dec 12, 2023

feat(DDS): import DDS resource, unit test and document #151

feat(DDS): import DDS resource, unit test and document #151

Conversation

Zippo-Wang commented Nov 16, 2023 • edited Loading

PR Checklist

Acceptance Steps Performed

github-ci-robot commented Nov 28, 2023

github-ci-robot commented Nov 29, 2023

github-actions bot commented Nov 30, 2023

github-ci-robot commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

Zhukun-Huawei Dec 8, 2023 • edited Loading

Choose a reason for hiding this comment

Zippo-Wang Dec 8, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 8, 2023

Zhukun-Huawei commented Dec 8, 2023

chengxiangdong commented Dec 12, 2023

Zippo-Wang commented Nov 16, 2023 •

edited

Loading

Zhukun-Huawei Dec 8, 2023 •

edited

Loading