Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(EVS): add a data source to query a list of EVS volumes #148

Merged
merged 1 commit into from
Dec 1, 2023
Merged

feat(EVS): add a data source to query a list of EVS volumes #148

merged 1 commit into from
Dec 1, 2023

Conversation

Zhukun-Huawei
Copy link
Contributor

@Zhukun-Huawei Zhukun-Huawei commented Nov 14, 2023 •
edited
Loading

What this PR does / why we need it:
transfer resource from huawei provider to G42 provider

Which issue this PR fixes:

import evs resource and add unit test and docs

Special notes for your reviewer:

Release note:

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

=== RUN   TestAccEvsVolumesDataSource_basic
=== PAUSE TestAccEvsVolumesDataSource_basic
=== CONT  TestAccEvsVolumesDataSource_basic
--- PASS: TestAccEvsVolumesDataSource_basic (406.82s)
PASS

@github-ci-robot
Copy link
Collaborator

PR needs rebase.

@chengxiangdong
Copy link
Collaborator

/assign

@github-ci-robot
Copy link
Collaborator

PR needs rebase.

@Zhukun-Huawei Zhukun-Huawei force-pushed the evs_branch branch 2 times, most recently from bc9b781 to c24166b Compare November 30, 2023 09:40
@github-actions github-actions bot added feature size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2023
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 30, 2023
@chengxiangdong
Copy link
Collaborator

/retitle feat(EVS): add a data source to query a list of EVS volumes
/lgtm
/approve

@github-ci-robot github-ci-robot added the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2023
@github-ci-robot github-ci-robot changed the title feat(evs): import evs resource and add unit test and docs feat(EVS): add a data source to query a list of EVS volumes Dec 1, 2023
@github-ci-robot github-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed LGTM "Looks good to me", indicates that a PR is ready to be merged. labels Dec 1, 2023
@chengxiangdong
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2023
@github-ci-robot github-ci-robot merged commit 773123f into g42cloud-terraform:main Dec 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees

@chengxiangdong chengxiangdong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zhukun-Huawei @github-ci-robot @chengxiangdong