Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing CPU tight loop if we have a visible image with nil content #5290

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Fixing CPU tight loop if we have a visible image with nil content #5290

merged 1 commit into from
Dec 1, 2024
+5 −1

Conversation

andydotxyz
Copy link
Member

Checklist:

  • Tests included. <- runtime CPU is high if you include an image object with no file or resource content
  • Lint and formatter run with no errors.
  • Tests all pass.

Jacalz
Jacalz requested changes Nov 30, 2024
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Minor suggestion inline :)

canvas/image.go Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 60.018% (+0.006%) from 60.012%
when pulling 4fa185d on andydotxyz:fix/nilimagespeed
into e8be3f6 on fyne-io:develop.

@andydotxyz andydotxyz merged commit 55a6e1d into fyne-io:develop Dec 1, 2024
12 checks passed
@andydotxyz andydotxyz deleted the fix/nilimagespeed branch December 1, 2024 21:42
@dweymouth
Copy link
Contributor

This probably fixes #4345

@andydotxyz
Copy link
Member Author

Thanks so much - I thought there was an issue but could not find it

@andydotxyz andydotxyz mentioned this pull request Dec 2, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andydotxyz @coveralls @dweymouth @Jacalz