-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix app.running field only being set if starting with app.Run() #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desktop driver already has this protection now. Move it into the mobile driver.
Jacalz
changed the title
Improvement to glfw driver init
Fix app.running field only being set if starting with app.Run()
Aug 24, 2023
The plan was initially to apply a re-roll of 460fa8d but it felt better to work on that separately. |
In testing with fyne_demo closing it I get this panic:
|
I haven't been able to replicate the crash but I pushed a commit that should solve it hopefully. |
andydotxyz
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes the
app.running
field only being set if running withapp.Run()
and not when usingwindow.ShowAndRun()
, i.e. it was false for the majority of applications. The glfw driver already had a flag to check if it was running or not. The PR moves the running flag into the mobile driver and cleans up the one we already had in the glfw driver.Checklist: