Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock canvas lock before refresh of image #4191

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Unlock canvas lock before refresh of image #4191

merged 1 commit into from
Aug 24, 2023

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Aug 24, 2023

Description:

Seems to fix #4086

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 65.324% (+0.01%) from 65.311% when pulling bb19f40 on Jacalz:fix-deadlock-on-ensure-minsize into 28ab690 on fyne-io:develop.

andydotxyz
andydotxyz approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sane, I like you have a new issue to cover refactoring locks.

@Jacalz Jacalz merged commit c361ad4 into fyne-io:develop Aug 24, 2023
11 checks passed
@Jacalz Jacalz deleted the fix-deadlock-on-ensure-minsize branch August 24, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jacalz @coveralls @andydotxyz