Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ellipsis for truncating select button #4187

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Ellipsis for truncating select button #4187

merged 1 commit into from
Aug 23, 2023

Conversation

andydotxyz
Copy link
Member

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Jacalz
Jacalz approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Are there any more places that could use this new truncation mode? File dialog items perhaps?

@andydotxyz andydotxyz merged commit d2475b9 into fyne-io:develop Aug 23, 2023
11 checks passed
@andydotxyz andydotxyz deleted the fix/selectellipsis branch August 23, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andydotxyz @Jacalz