Cleanup GLFW init to avoid needing a sync.Once #4177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that I accidentally pushed two unrelated commits here. Will move those out to a separate PR. |
andydotxyz
approved these changes
Aug 23, 2023
Jacalz
added a commit
to Jacalz/fyne
that referenced
this pull request
Aug 24, 2023
This reverts commit d2a24a9.
Jacalz
added a commit
to Jacalz/fyne
that referenced
this pull request
Nov 18, 2023
… with the application not having started. This cleans up some of the init code to avoid calling init multiple times (when starting and when creating a new windows). Replaces fyne-io#4177
Jacalz
added a commit
to Jacalz/fyne
that referenced
this pull request
Nov 18, 2023
This replaces my previous PR which had to be reverted due to an issue with the application not having started. This cleans up some of the init code to avoid calling init multiple times (when starting and when creating a new windows). It also includes an extra change to set up the device field more coherently. Replaces fyne-io#4177
Jacalz
added a commit
to Jacalz/fyne
that referenced
this pull request
Jan 6, 2024
This replaces my previous PR which had to be reverted due to an issue with the application not having started. This cleans up some of the init code to avoid calling init multiple times (when starting and when creating a new windows). It also includes an extra change to set up the device field more coherently. Replaces fyne-io#4177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We previously called
glfw.Init()before doing anything that needed it to be called (i.e. when creating a window and when starting the run loop) which led to init running multiple times. The solution was to protect it using async.Oncebut I realized that we can avoid it by just doing init on driver creation instead. This cleans up the code and makes window creation slightly faster as an added benefit.Checklist: