Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some driver code #4172

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Clean up some driver code #4172

merged 2 commits into from
Aug 21, 2023

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Aug 21, 2023

Description:

This backports some changes that I did while trying to solve #2506. It improves the performance slightly be allowing NewGLDriver() to be inlined (now cost 79, with 80 as limit) and removes an unnecessary field from runFlag. Nothing major just makes the code a bit cleaner.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@Jacalz Jacalz mentioned this pull request Aug 21, 2023
Closed
3 tasks
andydotxyz
andydotxyz approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner, thanks

@coveralls
Copy link

Coverage Status

coverage: 65.294% (-0.009%) from 65.303% when pulling 5a61cfd on Jacalz:driver-cleanup into 8be6541 on fyne-io:develop.

@Jacalz Jacalz merged commit 0a42b57 into fyne-io:develop Aug 21, 2023
@Jacalz Jacalz deleted the driver-cleanup branch August 21, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jacalz @coveralls @andydotxyz