extract duplicate code to importDataFromFile method

fuzzy69 · May 13, 2017 · 3cd08e5 · 3cd08e5
1 parent 5d63ba1
commit 3cd08e5
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/application/mainwindow.py b/application/mainwindow.py
@@ -126,14 +126,7 @@ def resizeTableColumns(self):
     def importUrls(self):
         filePath, fileType = QtWidgets.QFileDialog.getOpenFileName(self, "Import URLs", filter="Text files (*.txt)")
         if filePath:
-            text = readTextFile(filePath)
-            for url in text.strip().splitlines():
-                if url in self._urls:
-                    continue
-                self._urls.append(url)
-                rankCell = QStandardItem("")
-                rankCell.setTextAlignment(Qt.AlignCenter)
-                self.sitesModel.appendRow([QStandardItem(url), rankCell,QStandardItem("")])
+            self.importDataFromFile(filePath)
             self.updateRecentFiles(filePath)
 
     def sitesTableView_doubleClicked(self, modelIndex):
@@ -189,6 +182,9 @@ def updateRecentFilesActions(self):
 
     def openRecentFile(self):
         filePath = str(self.sender().data())
+        self.importDataFromFile(filePath)
+
+    def importDataFromFile(self, filePath):
         if os.path.exists(filePath):
             text = readTextFile(filePath)
             for url in text.strip().splitlines():