Feature/endpoint for removing image #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi
force-pushed
the
feature/endpoint-for-removing-image
branch
from
ed3ed40 to
e2bd976
Compare
kaupunki-apina
suggested changes
Jun 28, 2019
| return knex.raw(` | ||
| SELECT * | ||
| FROM images | ||
| WHERE id = ${req.params.id} |
There was a problem hiding this comment.
Prone to SQL injection. Should be...
knex.raw(`... WHERE id = ?`, req.params.id).then(...);| return Promise.all(rows.map(r => { | ||
| return knex.raw(` | ||
| DELETE FROM votes | ||
| WHERE id = ${r.id} |
| */ | ||
| function delImg(id) { | ||
| return knex.raw(` | ||
| DELETE FROM images WHERE id = ${id} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an endpoint which user can use to remove images he/she has uploaded