Angular 14. Fixes #153 #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks. 👍🏽 Would be great if this PR would receive some maintainer attention. |
|
Apparently FusionCharts is doing their own upgrade, which is good news (finally). Aldo some communication would be nice. It also looks like they focus on Angular 15, which is already out for 2 months. For that reason and with all these merge conflicts, I'm going to close this PR. I do hope their upgrade is better then their review process; 1e29b5c#r97467805 and a few other weird changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the whole project to support Angular 14.
Fixes #153 & #137 & #140 and probably many others!
angular-cli.jsontoangular.json.I got these change working in our companies project, but this requires full testing on all supported Angular versions, and probably even more clean up.
Why is there no automated testing setup?
Also, please don't publish the whole project to NPM, only the dist files are enough: https://unpkg.com/browse/[email protected]/