-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work with angular 14 #153
Comments
Here is a sample project, just run |
Is there a plan to start supporting angular 14 soon? |
As a workaround, you can put the "angular-fusioncharts"'s source code inside you Angular 14 project... And all should works fine |
@hebus Your workaround got it compiling, but actual loading of charts fails with ERROR TypeError: Cannot read properties of null (reading 'firstCreatePass') Any thoughts? Should I just use 13? |
Hello @epiphanizer , Don't worry, if does not work online, just download the source code and test it in local. This is how we have fixed Angular 14 compilation issues |
@hebus in angular 14 got compile successfully. but while load page throw error. ypeError: Cannot read properties of null (reading 'firstCreatePass'). Is it version issue? how can I resolve. |
@fusioncharts This discussion also started with Angular 12, then with version 13 and now with 14. For the previous versions, the upgrade was possible by forcing the upgrade. Angular 14 is out for 4+ months now. |
@fusioncharts I've created #154 to upgrade to Angular 14. |
@fusioncharts please merge #154 and make a new package for us to use. |
And now we are multiple version behind again, with Angular 15 just released. I don't know why I pay for this product !!! |
When I spoke to their support, they didn't even have an ETA, and their claim was - this is an open-source project, so we cannot expect them to deliver or support. unfortunately, they don't seem to know why or how open-source works: they are not even open to merging community patches. Unfortunately, moving away is not a simple decision either :-( @jerone would it be possible to publish your patched version as an unofficial package? |
The argument about being an open-source project is confusing. They maintain this repo, plus they mention support for Angular multiple times on their website. 1. 2. I'll contact them too, asking to prioritize this blocking issue.
Exactly, the work is already done #154 (if they confirm everything is working correctly).
I have to think about this and discuss this internally, as I forked this repo from my companies org. I try to stay away from publishing clones, because I cannot and will not give support if we unofficially publish it. |
Same issue trying to upgrade my app to Angular 14. We only purchased our license due to the fact that they said it "had support for Angular". |
This comment was marked as off-topic.
This comment was marked as off-topic.
@jerone how did u solved issue on angular 12? I have |
This comment was marked as off-topic.
This comment was marked as off-topic.
@jerone yeah, but u said
can you please clarify what do u mean by that. |
This comment was marked as off-topic.
This comment was marked as off-topic.
We are also paying customers and we are forced to upgrade to Angular 14. |
What a lamentable business. They need to remediate this things to avoid paying for a license for something that you cannot upgrade. |
@AdiSilagy We had to clone the repository and upgrade it ourselves. Then published to a private NPM package. |
@Franccescalee , how did you upgrade it? Please, let us know. |
@yuricamara I think I just changed the angular packages in the package.json to go to 14.x before I did an npm install. I compared what was in there to what I have in my app as well. Then built/packed/published. I don't remember needing to make any changes to the code. |
Hello, The latest version of angular-fusioncharts has just been released that is angular-fusioncharts 4.0.3 . This version supports angular version till the latest one (15). If you want you can upgrade the angular version and test your application. Here is the npm link : Demo - https://github.com/AyanBhadury/angular-fusioncharts-sample |
Super great news. I'll give it a try soon. 🎉 Can you please create an CHANGELOG to keep track of the changes. Preferably via the "Releases" tab. Many corporation need to track the changes. Are there for example no breaking changes? But more important, Angular 16 is less then 1 month away ("week of 2023-05-01").https://angular.io/guide/releases#release-schedule |
Sorry I don't have the permission, may be create a ticket to [email protected] and request them to add it. |
Follow the steps on the readme file but use angular 14 and you get this error when trying to run
ng serve
The text was updated successfully, but these errors were encountered: