RF: Flatten the window folder to the file #955
Conversation
- Flatten the window folder to the file. - Added all the pygfx imports from window file to lib. - Created jupyter-rfb as optional dependency under plot.
|
Hey @skoudoro , I have not added the docstring intentionally as It will change a lot in the upcoming PRs. I have also figured out some tests, It will create a change in a lot of files and a lot of places. I am breaking this big change in to small changes, that are easy to review. PS: This also tackles the issue of jupyter-rfb not being the optional dependency. |
- Optional package used to trigger tripwire. - Added pygfx and glfw to dependencies in pyproject.toml.
| # Classes that needed to be written as types | ||
| Camera: TypeAlias = gfx.Camera | ||
| Controller: TypeAlias = gfx.Controller | ||
| Scene: TypeAlias = gfx.Scene | ||
| Viewport: TypeAlias = gfx.Viewport |
There was a problem hiding this comment.
What do you need the TypeAlias here ?
There was a problem hiding this comment.
It gives pre-commit error as these classes are used to either extend the class or used as type in a dataclass.
There was a problem hiding this comment.
strange, ok, I look into it later, merging
There was a problem hiding this comment.
@skoudoro you can take a look at this. The pre-commit points to this resource when it gives the error. https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
RF: Flatten the window folder to the file
PR Contents
lib.py.jupyter-rfbas an optional dependency under the plot.