Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF: Add keyword arguments to module: animation #899

Merged
merged 1 commit into from
Jul 14, 2024
Merged

RF: Add keyword arguments to module: animation #899

merged 1 commit into from
Jul 14, 2024

Conversation

WassCodeur
Copy link
Member

  • apply warn_on_args_to_kwargs to the module animation
  • update the unitest

@skoudoro
Copy link
Contributor

Can you rebase to fix the conflict ? thanks

@WassCodeur WassCodeur force-pushed the add_keyword_only_animation branch from 6596a97 to 4e4e8bf Compare July 10, 2024 12:12
@skoudoro
Copy link
Contributor

Hi @WassCodeur,

there are problem in your rebase, we see blog posts in PR, we should not. we should see just your changes. Can you update.

Also, can you squash your commit.

Thank you

@skoudoro skoudoro force-pushed the add_keyword_only_animation branch from 4e4e8bf to 94f94d5 Compare July 10, 2024 16:17
@pep8speaks
Copy link

pep8speaks commented Jul 10, 2024 •
edited
Loading

Hello @WassCodeur, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, pip install flake8 and then run flake8 fury.

Comment last updated at 2024-07-11 21:37:34 UTC

@WassCodeur WassCodeur force-pushed the add_keyword_only_animation branch 3 times, most recently from bb207ee to 7299d4b Compare July 11, 2024 19:51
@WassCodeur WassCodeur closed this Jul 11, 2024
@WassCodeur WassCodeur force-pushed the add_keyword_only_animation branch from 7299d4b to 7651a24 Compare July 11, 2024 19:55
@WassCodeur WassCodeur reopened this Jul 11, 2024
skoudoro
skoudoro approved these changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, merging

@skoudoro skoudoro merged commit a1f635a into fury-gl:master Jul 14, 2024
34 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoudoro skoudoro skoudoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WassCodeur @skoudoro @pep8speaks